AutosarC++17_10-A12.8.2ΒΆ
User-defined copy and move assignment operators should use user-defined no-throw swap function
Required inputs: IR
| Level | advisory |
|---|---|
| Target | implementation |
| Enforcement | automated |
Rationale
Using a non-throwing swap operation in the copy and move assignment operators helps to achieve Strong Exception Safety. Each assignment operator is also simplified because it does not require check for assignment to itself.
Example
// $Id: A12-8-2.cpp 289436 2017-10-04 10:45:23Z michal.szczepankiewicz $
#include <cstdint>
#include <utility>
class A {
public:
A(const A &oth) {
// ...
}
A(A &&oth) noexcept {
// ...
}
A &operator=(const A &oth) & // Compliant
{
A tmp(oth);
Swap(*this, tmp);
return *this;
}
A &operator=(A &&oth) & noexcept // Compliant
{
A tmp(std::move(oth));
Swap(*this, tmp);
return *this;
}
static void Swap(A &lhs, A &rhs) noexcept {
std::swap(lhs.ptr1, rhs.ptr1);
std::swap(lhs.ptr2, rhs.ptr2);
}
private:
std::int32_t *ptr1;
std::int32_t *ptr2;
};
class B {
public:
B &operator=(const B &oth) & // Non-compliant
{
if (this != &oth) {
ptr1 = new std::int32_t(*oth.ptr1);
ptr2 = new std::int32_t(*oth.ptr2); // Exception thrown here results in
// a memory leak of ptr1
}
return *this;
}
B &operator=(B &&oth) & noexcept // Non-compliant
{
if (this != &oth) {
ptr1 = std::move(oth.ptr1);
ptr2 = std::move(oth.ptr2);
oth.ptr1 = nullptr;
oth.ptr2 = nullptr;
}
return *this;
}
private:
std::int32_t *ptr1;
std::int32_t *ptr2;
};
See Also
- HIC++ v4.0 [8]: 12.5.6 Use an atomic, non-throwing swap operation to implement the copy and move assignment operators
Possible Messages
Key |
Text |
Severity |
Disabled |
|---|---|---|---|
asgn_no_swap |
A move/copy assignment operator shall use a no-throw swap function. |
None |
False |
asgn_not_nothrow |
Used swap function is not no-throw. |
None |
False |
Options
This rule shares the following common options: confidence, exclude_in_macros, exclude_messages_in_system_headers, excludes, extend_exclude_to_macro_invocations, includes, justification_checker, languages, post_processing, provider, report_at, severity
The following places define options that affect this rule: Stylechecks, Analysis-GlobalOptions
This rule has no individual options.