AutosarC++18_03-A12.8.7ΒΆ

Assignment operators should be declared with the ref-qualifier &

Required inputs: IR

Rationale

User declared assignment operators differ from built-in operators in a way that they accept rvalues as parameters, which is confusing. Adding & to the function declaration prohibits rvalue parameters and ensures that all of the calls can only be made on lvalue objects, which results with the same behavior as for built-in types.

Note that this rule applies to all assignment operators, e.g. operator=(), operator*=(), operator+=.

Example
// $Id: A12-8-7.cpp 289436 2017-10-04 10:45:23Z michal.szczepankiewicz $
#include <cstdint>
class A {
public:
  A() = default;
  A &operator*=(std::int32_t i) // Non-compliant
  {
    // ...
    return *this;
  }
};
A F1() noexcept { return A{}; }
class B {
public:
  B() = default;
  B &operator*=(std::int32_t) & // Compliant
  {
    // ...
    return *this;
  }
};
B F2() noexcept { return B{}; }
std::int32_t F3() noexcept { return 1; }
int main(int, char **) {
  F1() *= 10; // Temporary result of f1() multiplied by 10. No compile-time
              // error.
  ;
  // f2() *= 10; // Compile-time error due to ref-qualifier
  ;
  // f3() *= 10; // Compile-time error on built-in type
}
See Also
  • HIC++ v4.0 [8]: 12.5.7 Declare assignment operators with the ref-qualifier &.
  • cppreference.com [15]: Assignment operators.

Possible Messages

Key

Text

Severity

Disabled

asgn_missing

Assignment operators should be declared with the ref-qualifier &.

None

False

Options