CertC-INT16¶
Do not make assumptions about representation of signed integers
Required inputs: IR
Although many common implementations use a two's complement representation of signed integers, the C Standard declares such use as implementation-defined and allows all of the following representations:
- Sign and magnitude
- Two's complement
- One's complement
This is a specific example of MSC14-C. Do not introduce unnecessary platform dependencies .
Noncompliant Code Example
One way to check whether a number is even or odd is to examine the least significant bit, but the results will be inconsistent. Specifically, this example gives unexpected behavior on all one's complement implementations:
int value;
if (scanf("%d", &value) == 1) {
if (value & 0x1 != 0) {
/* Take action if value is odd */
}
}
|
Compliant Solution
The same thing can be achieved compliantly using the modulo operator:
int value;
if (scanf("%d", &value) == 1) {
if (value % 2 != 0) {
/* Take action if value is odd */
}
}
|
Compliant Solution
Using bitwise operators is safe on unsigned integers:
unsigned int value;
if (scanf("%u", &value) == 1) {
if (value & 0x1 != 0) {
/* Take action if value is odd */
}
}
|
Risk Assessment
Incorrect assumptions about integer representation can lead to execution of unintended code branches and other unexpected behavior.
| Recommendation | Severity | Likelihood | Detectable | Repairable | Priority | Level |
|---|---|---|---|---|---|---|
| INT16-C | Medium | Unlikely | No | No | P2 | L3 |
Possible Messages
Key |
Text |
Severity |
Disabled |
|---|---|---|---|
bitop_on_enum |
Do not make assumptions about representation of signed integers |
None |
False |
bitop_on_signed |
Do not make assumptions about representation of signed integers |
None |
False |
Options¶
This rule shares the following common options: confidence, exclude_in_macros, exclude_messages_in_system_headers, excludes, extend_exclude_to_macro_invocations, includes, justification_checker, languages, post_processing, provider, report_at, severity
The following places define options that affect this rule: Stylechecks, Analysis-GlobalOptions
allow_shift_of_constant_if_sign_unchanged¶
allow_shift_of_constant_if_sign_unchanged : bool = False
require_possibly_negative_operand¶
require_possibly_negative_operand : bool = True